jiazhizhong/OpenIsle
1
0
Fork 0
mirror of https://github.com/nagisa77/OpenIsle.git synced 2026-02-24 23:20:49 +08:00
Code Issues Packages Projects Releases Wiki Activity

Deduplicate post view notifications

Browse Source
This commit is contained in:
Tim
2025-08-01 11:55:17 +08:00
parent e8e77b6467
commit db31b5d6c1
3 changed files with 28 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/main/java/com/openisle/repository/NotificationRepository.java
View File

@@ -18,4 +18,6 @@ public interface NotificationRepository extends JpaRepository<Notification, Long
List<Notification> findByComment(Comment comment);
void deleteByTypeAndFromUser(NotificationType type, User fromUser);
void deleteByTypeAndFromUserAndPost(NotificationType type, User fromUser, Post post);
}

3
src/main/java/com/openisle/service/NotificationService.java
View File

@@ -58,6 +58,9 @@ public class NotificationService {
public Notification createNotification(User user, NotificationType type, Post post, Comment comment, Boolean approved,
User fromUser, ReactionType reactionType, String content) {
if (type == NotificationType.POST_VIEWED && post != null && fromUser != null) {
notificationRepository.deleteByTypeAndFromUserAndPost(type, fromUser, post);
}
Notification n = new Notification();
n.setUser(user);
n.setType(type);

23
src/test/java/com/openisle/service/NotificationServiceTest.java
View File

@@ -168,4 +168,27 @@ class NotificationServiceTest {
verify(email).sendEmail("a@a.com", "有人回复了你", "https://ex.com/posts/1#comment-2");
verify(push).sendNotification(eq(user), contains("/posts/1#comment-2"));
}
@Test
void postViewedNotificationDeletesOldOnes() {
NotificationRepository nRepo = mock(NotificationRepository.class);
UserRepository uRepo = mock(UserRepository.class);
ReactionRepository rRepo = mock(ReactionRepository.class);
EmailSender email = mock(EmailSender.class);
PushNotificationService push = mock(PushNotificationService.class);
Executor executor = Runnable::run;
NotificationService service = new NotificationService(nRepo, uRepo, email, push, rRepo, executor);
org.springframework.test.util.ReflectionTestUtils.setField(service, "websiteUrl", "https://ex.com");
User owner = new User();
User viewer = new User();
Post post = new Post();
when(nRepo.save(any(Notification.class))).thenAnswer(i -> i.getArgument(0));
service.createNotification(owner, NotificationType.POST_VIEWED, post, null, null, viewer, null, null);
verify(nRepo).deleteByTypeAndFromUserAndPost(NotificationType.POST_VIEWED, viewer, post);
verify(nRepo).save(any(Notification.class));
}
}