From e971faeb0bb7d87b593ef7905a9ed5d29be92e44 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E6=BE=84=E6=BD=AD?= Date: Thu, 18 Jan 2024 10:30:56 +0800 Subject: [PATCH] remove useless kube client in nacos v1 watcher (#788) --- registry/nacos/watcher.go | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/registry/nacos/watcher.go b/registry/nacos/watcher.go index fdd075cf0..50c3212dc 100644 --- a/registry/nacos/watcher.go +++ b/registry/nacos/watcher.go @@ -26,9 +26,7 @@ import ( "github.com/nacos-group/nacos-sdk-go/model" "github.com/nacos-group/nacos-sdk-go/vo" "istio.io/api/networking/v1alpha3" - versionedclient "istio.io/client-go/pkg/clientset/versioned" "istio.io/pkg/log" - ctrl "sigs.k8s.io/controller-runtime" apiv1 "github.com/alibaba/higress/api/networking/v1" "github.com/alibaba/higress/pkg/common" @@ -61,7 +59,6 @@ type watcher struct { cache memory.Cache mutex *sync.Mutex stop chan struct{} - client *versionedclient.Clientset isStop bool updateCacheWhenEmpty bool authOption provider.AuthOption @@ -79,18 +76,6 @@ func NewWatcher(cache memory.Cache, opts ...WatcherOption) (provider.Watcher, er stop: make(chan struct{}), } - config, err := ctrl.GetConfig() - if err != nil { - return nil, err - } - - ic, err := versionedclient.NewForConfig(config) - if err != nil { - log.Errorf("can not new istio client, err:%v", err) - return nil, err - } - w.client = ic - w.NacosRefreshInterval = int64(DefaultRefreshInterval) for _, opt := range opts {