From db66df39c4aafcab22fea633dfbc0332fc489941 Mon Sep 17 00:00:00 2001 From: Xin Luo <65529035+luoxiner@users.noreply.github.com> Date: Fri, 20 Jun 2025 14:36:01 +0800 Subject: [PATCH] fix too much logs when nacos is not avaiable (#2469) --- registry/nacos/mcpserver/client.go | 7 ++++--- registry/nacos/mcpserver/watcher.go | 4 ++++ 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/registry/nacos/mcpserver/client.go b/registry/nacos/mcpserver/client.go index e9cb4f3d2..622dfdaec 100644 --- a/registry/nacos/mcpserver/client.go +++ b/registry/nacos/mcpserver/client.go @@ -141,12 +141,13 @@ func (n *NacosRegistryClient) listMcpServerConfigs() ([]model.ConfigItem, error) }) if err != nil { - mcpServerLog.Errorf("List mcp server configs for page size %d, page number %d error %v", currentPageNum, DefaultNacosListConfigPageSize) + mcpServerLog.Errorf("List mcp server configs for page size %d, page number %d error %v", currentPageNum, DefaultNacosListConfigPageSize, err) + break } if configPage == nil { - mcpServerLog.Errorf("List mcp server configs for page size %d, page number %d null %v", currentPageNum, DefaultNacosListConfigPageSize) - continue + mcpServerLog.Errorf("List mcp server configs for page size %d, page number %d null", currentPageNum, DefaultNacosListConfigPageSize) + break } result = append(result, configPage.PageItems...) diff --git a/registry/nacos/mcpserver/watcher.go b/registry/nacos/mcpserver/watcher.go index 13ebb3f8c..66d38350c 100644 --- a/registry/nacos/mcpserver/watcher.go +++ b/registry/nacos/mcpserver/watcher.go @@ -50,6 +50,8 @@ const ( DefaultNacosCacheDir = "/var/log/nacos/log/mcp/cache" DefaultNacosNotLoadCache = true DefaultNacosLogMaxAge = 3 + DefaultNacosLogMaxSize = 64 + DefaultNacosLogMaxBackups = 3 DefaultRefreshInterval = time.Second * 30 DefaultRefreshIntervalLimit = time.Second * 10 ) @@ -128,6 +130,8 @@ func NewWatcher(cache memory.Cache, opts ...WatcherOption) (provider.Watcher, er constant.WithNotLoadCacheAtStart(DefaultNacosNotLoadCache), constant.WithLogRollingConfig(&constant.ClientLogRollingConfig{ MaxAge: DefaultNacosLogMaxAge, + MaxSize: DefaultNacosLogMaxSize, + MaxBackups: DefaultNacosLogMaxBackups, }), constant.WithUpdateCacheWhenEmpty(w.updateCacheWhenEmpty), constant.WithNamespaceId(w.NacosNamespaceId),