fix: routing priorities are not working properly (#472)

Signed-off-by: charlie <qianglin98@qq.com>
This commit is contained in:
Qianglin Li
2023-08-11 09:55:33 +08:00
committed by GitHub
parent 35d5669b51
commit 49269b4303
5 changed files with 69 additions and 6 deletions

View File

@@ -482,6 +482,9 @@ func (m *IngressConfig) convertVirtualService(configs []common.WrapperConfig) []
vs := wrapperVS.VirtualService
vs.Gateways = gateways
// Sort, exact -> prefix -> regex
common.SortHTTPRoutes(routes)
for _, route := range routes {
vs.Http = append(vs.Http, route.HTTPRoute)
}

View File

@@ -170,7 +170,14 @@ func SortHTTPRoutes(routes []*WrapperHTTPRoute) {
isAllCatch := func(route *WrapperHTTPRoute) bool {
if route.OriginPathType == Prefix && route.OriginPath == "/" {
return true
if route.HTTPRoute.Match == nil {
return true
}
match := route.HTTPRoute.Match[0]
if len(match.Headers) == 0 && len(match.QueryParams) == 0 && match.Method == nil {
return true
}
}
return false
}

View File

@@ -599,11 +599,6 @@ func (c *controller) ConvertHTTPRoute(convertOptions *common.ConvertOptions, wra
} else {
convertOptions.HTTPRoutes[rule.Host] = wrapperHttpRoutes
}
// Sort, exact -> prefix -> regex
routes := convertOptions.HTTPRoutes[rule.Host]
IngressLog.Debugf("routes of host %s is %v", rule.Host, routes)
common.SortHTTPRoutes(routes)
}
return nil