From 0bb934073ad2db1b9123f5321f0d44746ed3abdc Mon Sep 17 00:00:00 2001
From: Jingze <52855280+Jing-ze@users.noreply.github.com>
Date: Wed, 13 Aug 2025 17:43:15 +0800
Subject: [PATCH] fix(golang-filter): fix mcp server contruct envoy filter unit
 test (#2757)

---
 pkg/ingress/kube/configmap/mcp_server_test.go | 21 ++-----------------
 1 file changed, 2 insertions(+), 19 deletions(-)

diff --git a/pkg/ingress/kube/configmap/mcp_server_test.go b/pkg/ingress/kube/configmap/mcp_server_test.go
index a2ab35fdd..c9ac19df7 100644
--- a/pkg/ingress/kube/configmap/mcp_server_test.go
+++ b/pkg/ingress/kube/configmap/mcp_server_test.go
@@ -566,7 +566,7 @@ func TestMcpServerController_ConstructEnvoyFilters(t *testing.T) {
 				MatchList: []*MatchRule{},
 				Servers:   []*SSEServer{},
 			},
-			wantConfigs: 2, // Both session and server filters
+			wantConfigs: 1, // Only session filter when no servers configured
 			wantErr:     nil,
 		},
 	}
@@ -744,24 +744,7 @@ func TestMcpServerController_constructMcpServerStruct(t *testing.T) {
 			mcp: &McpServer{
 				Servers: []*SSEServer{},
 			},
-			wantJSON: `{
-				"name": "envoy.filters.http.golang",
-				"typed_config": {
-					"@type": "type.googleapis.com/udpa.type.v1.TypedStruct",
-					"type_url": "type.googleapis.com/envoy.extensions.filters.http.golang.v3alpha.Config",
-					"value": {
-						"library_id": "mcp-server",
-						"library_path": "/var/lib/istio/envoy/golang-filter.so",
-						"plugin_name": "mcp-server",
-						"plugin_config": {
-							"@type": "type.googleapis.com/xds.type.v3.TypedStruct",
-							"value": {
-								"servers": []
-							}
-						}
-					}
-				}
-			}`,
+			wantJSON: "", // Return empty string when no servers configured
 		},
 		{
 			name: "with servers",