refactor: re-impl sdk3rd

internal/pkg/sdk3rd/apisix/api.go

@@ -1,16 +0,0 @@
-package apisix
-
-import (
-	"fmt"
-	"net/http"
-)
-
-func (c *Client) UpdateSSL(req *UpdateSSLRequest) (*UpdateSSLResponse, error) {
-	if req.ID == "" {
-		return nil, fmt.Errorf("1panel api error: invalid parameter: ID")
-	}
-
-	resp := &UpdateSSLResponse{}
-	err := c.sendRequestWithResult(http.MethodGet, fmt.Sprintf("/ssls/%s", req.ID), req, resp)
-	return resp, err
-}

internal/pkg/sdk3rd/apisix/api_update_ssl.go

@@ -0,0 +1,44 @@
+package apisix
+
+import (
+	"context"
+	"fmt"
+	"net/http"
+)
+
+type UpdateSSLRequest struct {
+	Cert   *string   `json:"cert,omitempty"`
+	Key    *string   `json:"key,omitempty"`
+	SNIs   *[]string `json:"snis,omitempty"`
+	Type   *string   `json:"type,omitempty"`
+	Status *int32    `json:"status,omitempty"`
+}
+
+type UpdateSSLResponse struct {
+	apiResponseBase
+}
+
+func (c *Client) UpdateSSL(sslId string, req *UpdateSSLRequest) (*UpdateSSLResponse, error) {
+	return c.UpdateSSLWithContext(context.Background(), sslId, req)
+}
+
+func (c *Client) UpdateSSLWithContext(ctx context.Context, sslId string, req *UpdateSSLRequest) (*UpdateSSLResponse, error) {
+	if sslId == "" {
+		return nil, fmt.Errorf("sdkerr: unset sslId")
+	}
+
+	httpreq, err := c.newRequest(http.MethodPut, fmt.Sprintf("/ssls/%s", sslId))
+	if err != nil {
+		return nil, err
+	} else {
+		httpreq.SetBody(req)
+		httpreq.SetContext(ctx)
+	}
+
+	result := &UpdateSSLResponse{}
+	if _, err := c.doRequestWithResult(httpreq, result); err != nil {
+		return result, err
+	}
+
+	return result, nil
+}

internal/pkg/sdk3rd/apisix/client.go

@@ -5,6 +5,7 @@ import (
 	"encoding/json"
 	"fmt"
 	"net/http"
+	"net/url"
 	"strings"
 	"time"
 
@@ -15,9 +16,21 @@ type Client struct {
 	client *resty.Client
 }
 
-func NewClient(serverUrl, apiKey string) *Client {
+func NewClient(serverUrl, apiKey string) (*Client, error) {
+	if serverUrl == "" {
+		return nil, fmt.Errorf("sdkerr: unset serverUrl")
+	}
+	if _, err := url.Parse(serverUrl); err != nil {
+		return nil, fmt.Errorf("sdkerr: invalid serverUrl: %w", err)
+	}
+	if apiKey == "" {
+		return nil, fmt.Errorf("sdkerr: unset apiKey")
+	}
+
 	client := resty.New().
 		SetBaseURL(strings.TrimRight(serverUrl, "/")+"/apisix/admin").
+		SetHeader("Accept", "application/json").
+		SetHeader("Content-Type", "application/json").
 		SetHeader("User-Agent", "certimate").
 		SetPreRequestHook(func(c *resty.Client, req *http.Request) error {
 			req.Header.Set("X-API-KEY", apiKey)
@@ -25,63 +38,69 @@ func NewClient(serverUrl, apiKey string) *Client {
 			return nil
 		})
 
-	return &Client{
-		client: client,
-	}
+	return &Client{client}, nil
 }
 
-func (c *Client) WithTimeout(timeout time.Duration) *Client {
+func (c *Client) SetTimeout(timeout time.Duration) *Client {
 	c.client.SetTimeout(timeout)
 	return c
 }
 
-func (c *Client) WithTLSConfig(config *tls.Config) *Client {
+func (c *Client) SetTLSConfig(config *tls.Config) *Client {
 	c.client.SetTLSClientConfig(config)
 	return c
 }
 
-func (c *Client) sendRequest(method string, path string, params interface{}) (*resty.Response, error) {
-	req := c.client.R()
-	if strings.EqualFold(method, http.MethodGet) {
-		qs := make(map[string]string)
-		if params != nil {
-			temp := make(map[string]any)
-			jsonb, _ := json.Marshal(params)
-			json.Unmarshal(jsonb, &temp)
-			for k, v := range temp {
-				if v != nil {
-					qs[k] = fmt.Sprintf("%v", v)
-				}
-			}
-		}
-
-		req = req.SetQueryParams(qs)
-	} else {
-		req = req.SetHeader("Content-Type", "application/json").SetBody(params)
+func (c *Client) newRequest(method string, path string) (*resty.Request, error) {
+	if method == "" {
+		return nil, fmt.Errorf("sdkerr: unset method")
+	}
+	if path == "" {
+		return nil, fmt.Errorf("sdkerr: unset path")
 	}
 
-	resp, err := req.Execute(method, path)
+	req := c.client.R()
+	req.Method = method
+	req.URL = path
+	return req, nil
+}
+
+func (c *Client) doRequest(req *resty.Request) (*resty.Response, error) {
+	if req == nil {
+		return nil, fmt.Errorf("sdkerr: nil request")
+	}
+
+	// WARN:
+	//   PLEASE DO NOT USE `req.SetResult` or `req.SetError` HERE! USE `doRequestWithResult` INSTEAD.
+
+	resp, err := req.Send()
 	if err != nil {
-		return resp, fmt.Errorf("apisix api error: failed to send request: %w", err)
+		return resp, fmt.Errorf("sdkerr: failed to send request: %w", err)
 	} else if resp.IsError() {
-		return resp, fmt.Errorf("apisix api error: unexpected status code: %d, resp: %s", resp.StatusCode(), resp.String())
+		return resp, fmt.Errorf("sdkerr: unexpected status code: %d, resp: %s", resp.StatusCode(), resp.String())
 	}
 
 	return resp, nil
 }
 
-func (c *Client) sendRequestWithResult(method string, path string, params interface{}, result interface{}) error {
-	resp, err := c.sendRequest(method, path, params)
+func (c *Client) doRequestWithResult(req *resty.Request, res apiResponse) (*resty.Response, error) {
+	if req == nil {
+		return nil, fmt.Errorf("sdkerr: nil request")
+	}
+
+	resp, err := c.doRequest(req)
 	if err != nil {
 		if resp != nil {
-			json.Unmarshal(resp.Body(), &result)
+			json.Unmarshal(resp.Body(), &res)
 		}
-		return err
+		return resp, err
 	}
 
-	if err := json.Unmarshal(resp.Body(), &result); err != nil {
-		return fmt.Errorf("apisix api error: failed to unmarshal response: %w", err)
+	if len(resp.Body()) != 0 {
+		if err := json.Unmarshal(resp.Body(), &res); err != nil {
+			return resp, fmt.Errorf("sdkerr: failed to unmarshal response: %w", err)
+		}
 	}
 
-	return nil
+	return resp, nil
 }

internal/pkg/sdk3rd/apisix/models.go

@@ -1,12 +0,0 @@
-package apisix
-
-type UpdateSSLRequest struct {
-	ID     string    `json:"-"`
-	Cert   *string   `json:"cert,omitempty"`
-	Key    *string   `json:"key,omitempty"`
-	SNIs   *[]string `json:"snis,omitempty"`
-	Type   *string   `json:"type,omitempty"`
-	Status *int32    `json:"status,omitempty"`
-}
-
-type UpdateSSLResponse struct{}

internal/pkg/sdk3rd/apisix/types.go

@@ -0,0 +1,7 @@
+package apisix
+
+type apiResponse interface{}
+
+type apiResponseBase struct{}
+
+var _ apiResponse = (*apiResponseBase)(nil)