refactor: clean code

This commit is contained in:
Fu Diwei
2025-01-17 18:01:47 +08:00
parent dab6ad917c
commit 0869eaafdd
12 changed files with 50 additions and 57 deletions

View File

@@ -17,22 +17,22 @@ type settingsRepository interface {
}
type NotifyService struct {
settingRepo settingsRepository
settingsRepo settingsRepository
}
func NewNotifyService(settingRepo settingsRepository) *NotifyService {
func NewNotifyService(settingsRepo settingsRepository) *NotifyService {
return &NotifyService{
settingRepo: settingRepo,
settingsRepo: settingsRepo,
}
}
func (n *NotifyService) Test(ctx context.Context, req *domain.NotifyTestPushReq) error {
setting, err := n.settingRepo.GetByName(ctx, "notifyChannels")
settings, err := n.settingsRepo.GetByName(ctx, "notifyChannels")
if err != nil {
return fmt.Errorf("failed to get notify channels settings: %w", err)
}
channelConfig, err := setting.GetNotifyChannelConfig(req.Channel)
channelConfig, err := settings.GetNotifyChannelConfig(req.Channel)
if err != nil {
return fmt.Errorf("failed to get notify channel \"%s\" config: %w", req.Channel, err)
}